Trim AUTO_INCREMENT values from MySQL schema dumps #319

shames0 · 2022-09-20T23:07:04Z

closes #56

amacneil · 2022-09-20T23:37:50Z

pkg/driver/mysql/mysql.go

+}
+
+// TrimAutoincrementValues removes AUTO_INCREMENT values from MySQL schema dumps
+func TrimAutoincrementValues(data []byte) []byte {


I think this can start with a lowercase letter since it does not need to be exported?

amacneil · 2022-09-20T23:38:05Z

Looks like a great start. Can you also add some tests for it?

shames0 · 2022-09-20T23:44:30Z

Thanks for the feedback, I'll look at adding tests later this evening.

shames0 · 2022-09-22T16:10:38Z

Tests added, ready for any other feedback you might have. This is my first time writing GO... so feel free to nudge me toward best practices.

pkg/driver/mysql/mysql_test.go

amacneil · 2022-09-23T04:00:39Z

thank you!

pkg/driver/mysql/mysql_test.go

shames0 added 3 commits September 20, 2022 17:04

Trim AUTO_INCREMENT= values from MySQL schema dumps

4e8217a

Fix variable name to not be snake_case

913e3b8

Fix order of imports and format of return type

33d5ef5

amacneil reviewed Sep 20, 2022

View reviewed changes

shames0 added 2 commits September 21, 2022 22:32

Lower-case method name since it's not being exported

bfafd17

Add tests that check for trimAutoincrementValues side-effects

801121e

shames0 requested a review from amacneil September 23, 2022 00:41