New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickhouse: Fix CheckMigrationTableExists #387

Merged

amacneil merged 2 commits into amacneil:main from docapotamus:fix-clickhouse-status

Feb 20, 2023

Contributor

docapotamus commented Feb 20, 2023 •

edited

Loading

Checking for the migration tables existence in Clickhouse shouldn't pass a parameter.

This could be acheived one of two ways:

Use Sprintf to add the table name to the query (this is what is used elsewhere within the Clickhouse driver)
Check the information_schema using currentDatabase().

Opted for the first as that is what is used elsewhere.

Fixes #301

docapotamus added 2 commits

February 20, 2023 15:04


          Clickhouse: Fix CheckMigrationTableExists

edcdd55

Checking for the migration tables existence in Clickhouse shouldn't pass
a parameter.


          Fix lint error with ineffectual assignment

aed1860

Owner

amacneil commented Feb 20, 2023

thanks!

amacneil merged commit 447ea69 into amacneil:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment