Add line/column/position details to Postgres migration/rollback query error messages #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dossy
force-pushed
the
feature/add-detailed-error-message
branch
from
58b6d52
to
275044e
Compare
… error messages Postgres's database driver returns the character position where a syntax error occurs, so dbmate can use that information to calculate the line and column within the query that the position refers to. Co-authored-by: Jae B <doogie1012@gmail.com> Co-authored-by: Adrian Macneil <adrian@adrianmacneil.com>
dossy
force-pushed
the
feature/add-detailed-error-message
branch
from
275044e
to
af904ff
Compare
|
Nice work, thank you @dossy and @silbinarywolf |
amacneil
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres's database driver returns the character position where a syntax error occurs, so dbmate can use that information to calculate the line and column within the query that the position refers to.
This PR supersedes the work from PR #204, simplifying the implementation a bit by minimizing the amount of code change required, plus adding additional tests, including SQL queries with UTF-8 characters present.