Fix bug which ignored AMADEUS_HOST property provided by environment #18
Conversation
API documentation suggests that the user can pass a custom domain to which the client will issue api calls, by setting a AMADEUS_HOST property in the system environment variable. This functionality was however broken due to a typo while reading the environment variable. Fix bug by correcting the typo, thus picking the correct env variable
|
Thank you for your contribution! The version 1.1.2 should be published tomorrow. |
|
I deployed the new version, it always takes a few minutes/hours to be available on Maven Central. Thanks again for your contribution! 👍 |
|
My pleasure. On an unrelated note, I noticed that you do not have a Golang client yet for your APIs. I have started developing one from scratch in my local workspace. I was wondering if you would be interested to accept contributions. |
|
We are more than happy to accept contributions and even to work together to build it! Actually my colleague @alnacle is working on a Golang version of our SDK, would you be interested to have a short call to talk about it and see how we can work together? You can contact me at: Anthony.roux[at]amadeus.com |
|
Awesome. Thank you. I have sent you a mail on your email to follow-up. |
API documentation suggests that the user can pass a custom domain to
which the client will issue API calls, by setting an AMADEUS_HOST
property in the system environment variable. This functionality was
however broken due to a typo while reading the environment variable.
Fix bug by correcting the typo, thus picking the correct env variable.