Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme (with valid data) #39

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Update readme (with valid data) #39

merged 2 commits into from
Jan 14, 2020

Conversation

tsolakoua
Copy link
Member

No description provided.

@tsolakoua tsolakoua requested a review from alnacle January 8, 2020 15:02
@tsolakoua tsolakoua marked this pull request as ready for review January 8, 2020 16:36
@tsolakoua tsolakoua changed the title Update readme dates Update readme (with valid data) Jan 9, 2020
anthonyroux
anthonyroux suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@anthonyroux anthonyroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could update the LFS example as well so we don't forget to do it later.

We need to update the 3 examples in the classes as well:

https://github.com/amadeus4dev/amadeus-java/blob/master/src/main/java/com/amadeus/shopping/FlightOffers.java
image

anthonyroux
anthonyroux approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@anthonyroux anthonyroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@tsolakoua tsolakoua merged commit d295958 into master Jan 14, 2020
@tsolakoua tsolakoua deleted the update-docs branch April 6, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyroux anthonyroux anthonyroux approved these changes

@alnacle alnacle Awaiting requested review from alnacle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsolakoua @anthonyroux