Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Flight Order #51

Merged
merged 5 commits into from
Mar 3, 2020
Merged

Support for Flight Order #51

merged 5 commits into from
Mar 3, 2020

Conversation

tsolakoua
Copy link
Member

No description provided.

@tsolakoua tsolakoua marked this pull request as ready for review February 21, 2020 10:51
README.md Outdated
@@ -238,6 +238,10 @@ FlightOfferSearch[] flightOffersSearches = amadeus.shopping.flightOffersSearch.g
// body can be a String version of your JSON or a JsonObject
FlightOfferSearch[] flightOffersSearches = amadeus.shopping.flightOffersSearch.post(body);

// Flight Order Management
// The flightOrderID comes from the Flight Create Orders (in test environment it's temporary)
com.amadeus.resources.FlightOrder order = amadeus.booking.flightOrder("eJzTd9f3NjIJdzUGAAp%2fAiY=").get();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid using fully-qualified name of the class, like in the rest of the examples?
The argument to amadeus.booking.flightOrder() is a flightOrderID - this fact is not very obvious.

src/main/java/com/amadeus/Booking.java Show resolved Hide resolved
src/main/java/com/amadeus/Booking.java Show resolved Hide resolved
src/main/java/com/amadeus/booking/FlightOrder.java Outdated Show resolved Hide resolved
*
* <pre>
* com.amadeus.resources.FlightOrder order = amadeus.booking.flightOrder.(
* "eJzTd9f3NjIJdzUGAAp%2fAiY=").get();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention that "eJzTd9f3NjIJdzUGAAp%2fAiY=" is an example?

}

@ToString
public class Traveler {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no existing class for "Traveler" entity?


@ToString
public class Name {
protected Name() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same - Is there a specific reason to override the constructor?

@ToString
public class Phone {

protected Phone() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same - Is there a specific reason to override the constructor?


@ToString
public class Document {
protected Document() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same - Is there a specific reason to override the constructor?


@ToString
public class Contact {
protected Contact() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same - Is there a specific reason to override the constructor?

Copy link
Contributor

@alnacle alnacle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@akshitsingla akshitsingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our discussions, there are few updates that we skipped to maintain consistency of the rest of the SDK code. There should be a separate issue to fix these architectural decisions in the future.

@tsolakoua tsolakoua merged commit ee7d849 into master Mar 3, 2020
@tsolakoua tsolakoua deleted the flight-order branch March 3, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants