Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flight Create Orders #54

Merged
merged 9 commits into from
Mar 12, 2020
Merged

Flight Create Orders #54

merged 9 commits into from
Mar 12, 2020

Conversation

tsolakoua
Copy link
Member

@tsolakoua tsolakoua commented Mar 5, 2020 •
edited
Loading

Fixes #32

@tsolakoua tsolakoua marked this pull request as ready for review March 11, 2020 11:31
anthonyroux
anthonyroux suggested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@anthonyroux anthonyroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, this is a difficult one!

  • Fix the merge conflicts
  • Move the example into a dedicated file
  • Put a link to the example file into the readme

README.md Outdated
// Book a flight with Flight Create Orders
// Using a JSonObject
JsonObject result = flightOffers[0].getResponse().getResult();
FlightOrder createdOrder = amadeus.booking.flightOrders.pricing.post(result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work no? The JSON needs more than this information?

src/main/java/com/amadeus/booking/FlightOrders.java Outdated
* </p>
*
* <pre>
* amadeus.booking.flightOrders.post(body);</pre>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with object not body

anthonyroux
anthonyroux approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@anthonyroux anthonyroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job Anna :)!

@tsolakoua tsolakoua merged commit 8ed52c6 into master Mar 12, 2020
@tsolakoua tsolakoua deleted the create-orders branch March 12, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyroux anthonyroux anthonyroux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Flight Create Orders API
2 participants
@tsolakoua @anthonyroux