Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify configuration of maven-surefire-plugin #206

Merged

Conversation

Godin
Copy link
Contributor

@Godin Godin commented Oct 23, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 99.612% when pulling cbb85a9 on Godin:simplify_configuration_of_maven-surefire-plugin into 35b8ba3 on amaembo:master.

@amaembo amaembo merged commit e9d3501 into amaembo:master Oct 23, 2019
@amaembo
Copy link
Owner

amaembo commented Oct 23, 2019

Thanks. I don't remember why it didn't work for me for the first time. What about the coverage of shared files? Will it be taken from the first run, from the second run or from both runs?

@Godin
Copy link
Contributor Author

Godin commented Oct 23, 2019

@amaembo from both runs.

In case of appending you get

$ java -jar ./jacoco-0.8.5/lib/jacococli.jar execinfo target/jacoco.exec
[INFO] Loading exec file target/jacoco.exec.
CLASS ID         HITS/PROBES   CLASS NAME
Session "Godins-new-iMac.lrc.sonarsource.com-c8d6c77d": Wed Oct 23 21:07:39 CEST 2019 - Wed Oct 23 21:07:48 CEST 2019
387b9ae064c57edb  517 of 547   one/util/streamex/DoubleStreamExTest
...
Session "Godins-new-iMac.lrc.sonarsource.com-1d59fd3e": Wed Oct 23 21:07:49 CEST 2019 - Wed Oct 23 21:07:57 CEST 2019
387b9ae064c57edb  517 of 547   one/util/streamex/DoubleStreamExTest
...

In case of two files these two sessions are just in two different files and merged at a time of generation of report. And this is the same operation as "merge":

$ java -jar ./jacoco-0.8.5/lib/jacococli.jar merge target/jacoco_java8.exec target/jacoco_java9.exec --destfile target/jacoco.exec
[INFO] Loading execution data file /private/tmp/streamex/target/jacoco_java8.exec.
[INFO] Loading execution data file /private/tmp/streamex/target/jacoco_java9.exec.
[INFO] Writing execution data to /private/tmp/streamex/target/jacoco.exec.

$ java -jar ./jacoco-0.8.5/lib/jacococli.jar execinfo target/jacoco.exec | grep DoubleStreamExTest
387b9ae064c57edb  517 of 547   one/util/streamex/DoubleStreamExTest

@Godin Godin deleted the simplify_configuration_of_maven-surefire-plugin branch October 23, 2019 19:21
@Godin
Copy link
Contributor Author

Godin commented Oct 23, 2019

Splitting on two files is useful if you don't always merge and want to see runs separately.

@amaembo
Copy link
Owner

amaembo commented Oct 23, 2019

Well, I cannot say now whether something did not work for me, or I just failed to check this approach. You may add a comment to the Habr post though :-)

@Godin
Copy link
Contributor Author

Godin commented Oct 23, 2019

Well, nowadays I only read Habr and stopped commenting on it a long time ago... maybe you can update post? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants