navigation drawer improvements

[cpg]

The following are some changes I would suggest we do for the nav drawer:

• the small Amahi dice logos next to "Shares" and "Apps" are superfluous and overloading. Maybe a folder for Shares and some other one for Apps
• the name of the server disappears sometimes, just shows the literal string Server Name which is confusing. I did not change the server! -- I think this should be reproducible by rotating he phone.
• the Amahi dice logo inside the circle is truly abominable to look at. two corners touch the edge of the circle (!!). The word "Server" looks out of place.
• the flipping the arrow to select another server just looks flat wrong
• the circle with the first letter of the server name looks neat, etc., though the colors are very bright and seem out of place with the theme of the app.
• the first one (circle around the first letter of the server) is bright green and the letter inside is while, which makes it virtually impossible to see.

[arihant-001]

ways in which above changes can be implemented:

• Icons for shares and apps
  
• server name disappearing on rotation can be fix using save state. Also for the first time when no server is selected, list of servers will be shown and flip arrow would be invisible.
• Instead of Server, we can show Selected Server: and amahi logo in a circle will be replaced by this type of image
• Flip arrow will be used to show the list of servers
• For servers, if circles of random colors seem out of place with the app theme, then they can be replaced by a unique color like this
  

@cpg, @octacode please give your suggestions.

[cpg]

I am not sure about the Selected Server: ... because I think Selected is implicit and the colon may be superfluous.

The icons look great.

I kind of like the color selections in the circles (the color chosen were kind of a nice selection, which was, let's just say unusual for the typical developer), but perhaps a single color is more mainstream. If you choose a blue, please use a blue that is compatible with the rest of the app's blue colors. I like https://coolors.co/ and you can fix one color and it find shades for it automatically.

[arihant-001]

From above, I came to the following conclusion:

1. Selected will be use in place of Server text (or neither of them is necessary. Only server name would be enough to understand that this is server)
2. This color for servers will be fine. This is the app primary color (used for toolbar/ action bar)
   

There still one thing left to discuss, the amahi logo in the circle.
@cpg should we replace it with this

[octacode]

Also for the first time when no server is selected, list of servers will be shown and flip arrow would be invisible.

I would like to keep the present implementation of keeping the first server as default. Usually people have a single server and the first server is default.

The color (primarycolor) and the icon looks great to me. However, the letters W and T aren't actually in the center of the circle, If my eyes are right. Try to make them center align.

However the BIG Amahi dice backdrop looks pretty wierd to me. We should decrease the height of the navigation_header. Maybe that'll look better.

Also, I'd suggest to reduce the font of the server name (Welcome to Amahi) under Selected HDA: in the navigation header. It looks a bit superfluos to me.

Yes, we should remove the Amahi logo from the ActionBar in this activity but not from all other activities.

[arihant-001]

@octacode I will improve the drawer as suggested above.

• what if we make Welcome to Amahi server as the default.
• change drawer height to full screen, this way we do not need to remove the amahi logo from the action bar.

[octacode]

• No, if there's any other server besides the Welcome to Amahi server available then that should be the default like now.
• Alright, we can make the drawer height full screen. I guess that's also what the material design guidelines say.

[cpg]

clarification. i thinkSelected is implicit, which means it's not necessary. hence Server should be enough