Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Design Implementations #376

Closed
arihant-001 opened this issue Jun 10, 2018 · 23 comments
Closed

Material Design Implementations #376

arihant-001 opened this issue Jun 10, 2018 · 23 comments

Comments

@arihant-001
Copy link
Collaborator

The following features can be implemented in the app:

  • Improvement in the Navigation Drawer as suggested here plus navigation drawer height can be change to full-screen height for better user attention (also, in this way we do not need to hide amahi logo present in the action bar)
  • Theme feature: This will allow the user to change app theme. UI flow will be like:
    • A Theme option will be there in the Settings Fragment
    • This will open a list of themes(Dark and light theme).
    • Updating the apps color accordingly
@sanjitchak
Copy link
Contributor

The idea of full-screen height Navigation Drawer is great and I tried to pull it off too.
Much code had to be changed so, I dropped it, maybe for later.
Trying checking the code for navigation drawer @ARIHANTJAIN456 and see whether you may pull that off. It would be great.
Let's see what our mentors say.

@harshendrashah
Copy link

The theme of this app isn't user-friendly.
Can I work towards changing the entire-theme?? @ARIHANTJAIN456

@arihant-001
Copy link
Collaborator Author

@harshendrashah can you give specifics about changes you want to implement?

@harshendrashah
Copy link

Most of the users use our app only if it looks good. As a first time user, anybody sees the UI first and features next. As this app uses a dark theme, the colour combinations seem a bit dull, to be honest. Therefore, I am proposing a complete change in the colour scheme and theme of the app. And make it more attractive for the user. @ARIHANTJAIN456

@arihant-001
Copy link
Collaborator Author

arihant-001 commented Aug 23, 2018

Well, the dark theme was chosen as this is a multimedia app and there are many multimedia apps which use dark themes.
Can you provide some screenshots for the new theme and elaborate how it will be better than the current theme?

@cpg
Copy link
Member

cpg commented Aug 24, 2018

@harshendrashah We're always looking to improve our apps. We'll be happy if you can improve the looks of the app. We can provide a few screenshots for you to improve on, or you can take screenshots yourself while you use the app and then modify them (or use them as inspiration) to make your suggestions to improve the app.

Looking forward to your suggestions!

@harshendrashah
Copy link

@cpg Sir, I would like to have your advice. If you can provide some screenshots for improvements, it will be a great help.
I am also working on some designs and will let you know about them in a day or two.

Thanks!

@harshendrashah
Copy link

My idea is to change the theme to https://www.materialpalette.com/deep-purple/deep-orange this.
And another one is to colourize the app on dark blue shades.
Also waiting for your screenshots, they would be a great inspiration.

@cpg
Copy link
Member

cpg commented Aug 24, 2018

No. You have communicated by email that you have compiled and installed the app. Therefore you have all the screenshots you want at your fingertips.

@harshendrashah
Copy link

Ohh, Sorry I thought you have some ideas need to be implemented in the design. Therefore I asked for the screenshots.
I will post the screenshots of my new designs by tomorrow.

@harshendrashah
Copy link

@cpg and @ARIHANTJAIN456 Here are the screenshots of my design:

screenshot_2018-08-25-01-11-28-598_org amahi anywhere
screenshot_2018-08-25-00-58-17-058_org amahi anywhere
screenshot_2018-08-25-00-55-47-595_org amahi anywhere
screenshot_2018-08-25-00-56-04-476_org amahi anywhere
screenshot_2018-08-25-00-57-44-157_org amahi anywhere

@harshendrashah
Copy link

I am working on a dark theme too. Will update you soon.

@harshendrashah
Copy link

If you like this design, please let me know I'll send a PR.

@cpg
Copy link
Member

cpg commented Aug 26, 2018

Personally, I am not a fan of the login page. It burns my retina.

The rest being so bright is not my cup of tea, though not bad.

As for the login page and header's explosive color, though, I fail to see how these are any better.

@jddeep
Copy link

jddeep commented Feb 7, 2019

Personally, I am not a fan of the login page. It burns my retina.

The rest being so bright is not my cup of tea, though not bad.

As for the login page and header's explosive color, though, I fail to see how these are any better.

@cpg Hello! Can I work on this issue and improve the theme and UI?

@cpg
Copy link
Member

cpg commented Feb 7, 2019 via email

@jddeep
Copy link

jddeep commented Feb 8, 2019

@cpg cool. So where should I propose about my idea? here only??

@octacode
Copy link
Member

octacode commented Feb 8, 2019

Yes, you can share your screenshots here

@jddeep
Copy link

jddeep commented Feb 8, 2019

Ok thanks then.

@jddeep
Copy link

jddeep commented Feb 8, 2019

screenshot_20190208-114538

@cpg please take a look at this. Do you want a welcome text above the form?
And I could not look into other screens as I don't have an account and cannot sign in. I understand that Amahi is a home server and without the server, the app won't be usable. But me being a developer how can I work on the different parts of the app as I don't have an Amahi home server in my home? Help me out on this. Cheers!

@octacode
Copy link
Member

octacode commented Feb 8, 2019

Hi @jddeep, setting up the the Amahi server is an important part of the development. You will be able to make much more significant contributions once you have done that.
I'd recommend that you set up the server on a VM like me and many of the developers.

https://viky.co.in/2017/05/20/install-amahi-server-for-development/

This blog might help you do so.

Also, I would recommend that you ask doubts related to setting up your server on our irc.

@chirag-jn
Copy link
Member

Since in the current version of the app in the beta branch, we already have a light and dark theme, I guess we can close this issue.

@cpg
Copy link
Member

cpg commented Jul 7, 2020

Closing because we have light/dark theme support by now.

@cpg cpg closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants