Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing the ListView with Recycler View. #34

Merged
merged 3 commits into from
Mar 14, 2017
Merged

Conversation

octacode
Copy link
Member

@octacode octacode commented Mar 7, 2017

Recycler view is a part of android support library. So a new library has been added

I have tried to make the recycler view look exactly as the list view. Here's a pic:
fixes #29

@cpg
Copy link
Member

cpg commented Mar 7, 2017

Logistically it may be better if you submit the PR once you are done.

Tried it and it looks good (though I cannot tell the difference).

@octacode
Copy link
Member Author

octacode commented Mar 7, 2017

@cpg I'll do so. Yes one can't actually tell the difference but scrolling performance of RecyclerView is better than ListView.

@octacode octacode closed this Mar 7, 2017
@octacode octacode reopened this Mar 7, 2017
@cpg
Copy link
Member

cpg commented Mar 14, 2017

Could you resolve the conflicts and I will test it out? Thanks.

@octacode
Copy link
Member Author

@cpg will do so. 😊

@cpg cpg closed this Mar 14, 2017
@cpg cpg reopened this Mar 14, 2017
@cpg cpg merged commit af02dd2 into amahi:master Mar 14, 2017
@octacode octacode deleted the recV branch August 14, 2017 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants