Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test runner and test rules update #654

Merged
merged 5 commits into from Sep 26, 2020
Merged

Added test runner and test rules update #654

merged 5 commits into from Sep 26, 2020

Conversation

Akash-Ramjyothi
Copy link
Member

@Akash-Ramjyothi Akash-Ramjyothi commented Aug 31, 2020

Updated test:runner from 1.2.0 to 1.3.0 and test:rules from 1.2.0 to 1.3.0.

Tasks:

  • Remove ActivityTestRule

@chirag-jn
Copy link
Member

chirag-jn commented Aug 31, 2020

From test:runner 1.3.0 release notes, ActivityTestRule is deprecated in favor of ActivityScenario/ActivityScenarioRule
However, we are using ActivityTestRule.

@cpg
Copy link
Member

cpg commented Aug 31, 2020

  • please fix the conflict
  • please update the deprecation, so it does not break soon

@chirag-jn
Copy link
Member

From test:runner 1.3.0 release notes, ActivityTestRule is deprecated in favor of ActivityScenario/ActivityScenarioRule
However, we are using ActivityTestRule.

https://developer.android.com/jetpack/androidx/releases/test#1.3.0

@cpg
Copy link
Member

cpg commented Sep 7, 2020

Breaks travis.

Since it’s deprecated, shouldn't we look into the the replacement?

Is it hard to implement a proper the replacement?

@Akash-Ramjyothi
Copy link
Member Author

In version 1.3.0, the ActivityTestRule is deprecated in favor of ActivityScenario/ActivityScenarioRule. I am trying to implement ActivityScenario/ActivityScenarioRule right now.

@Akash-Ramjyothi
Copy link
Member Author

On implementing ActivityScenario/ActivityScenarioRule it caused some errors. According to me, I see 2 ways, one is to close it or the other is to merge it with deprecated test rules.

@chirag-jn
Copy link
Member

Is there no way to solve those errors? Functionality won't be removed in a new library obviously, it will just be offered in a different way.

@Akash-Ramjyothi
Copy link
Member Author

Akash-Ramjyothi commented Sep 8, 2020

@chirag-jn i request you to specify on how to implement your library with version 1.3.0

@chirag-jn
Copy link
Member

chirag-jn commented Sep 8, 2020

@chirag-jn i request you to specify on how to implement your library with version 13.0

Was this comment intended for this PR only?

@Akash-Ramjyothi
Copy link
Member Author

Yes. I would like you to specify how to implement ActivityScenarioRule with test runner version 1.3.0.

@chirag-jn
Copy link
Member

Yes. I would like you to specify how to implement ActivityScenarioRule with test runner version 1.3.0.

Oh, you earlier specified 13.0 instead of 1.3.0 which caused the confusion.

@cpg
Copy link
Member

cpg commented Sep 9, 2020

Adding that library appears to make it not break Travis. What's the better solution? Merge or close?

@chirag-jn
Copy link
Member

Adding that library appears to make it not break Travis. What's the better solution? Merge or close?

Since the required class is deprecated and not removed in v1.3.0, there's no harm in merging it.

@cpg cpg merged commit 40978c8 into amahi:beta Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants