Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support displaying images #22

Closed
fountainer opened this issue Jul 25, 2020 · 8 comments
Closed

Support displaying images #22

fountainer opened this issue Jul 25, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@fountainer
Copy link

It will be nice if orgro supports displaying images.
@amake
Copy link
Owner

amake commented Jul 25, 2020

I assume the kinds of images you are mostly concerned with would be local files alongside your org document?

For that we would need #5.

Remote images are easier, but we'd probably want some sort of caching mechanism.

@amake amake added the enhancement New feature or request label Jul 25, 2020
@fountainer
Copy link
Author

Yes. I want to display images alongside org files.

@alensiljak
Copy link

With #35, this should be fairly trivial (hopefully!).

@alensiljak alensiljak mentioned this issue Mar 13, 2021
Closed
@amake amake changed the title support displaying images Support displaying images Mar 18, 2021
@amake amake mentioned this issue Mar 19, 2021
Closed
@amake
Copy link
Owner

amake commented Apr 26, 2021

This will be implemented in v1.18.0, which will be available for testing soon:

See here for details and caveats.

amake added a commit that referenced this issue Apr 26, 2021
@amake
Display relatively linked images
2f86c2d 
See #22
@amake
Copy link
Owner

amake commented Apr 27, 2021

v1.18.0 is now available for testing on Test Flight and Google Play.

@fountainer
Copy link
Author

v1.18.0 is now available for testing on Test Flight and Google Play.

The LaTeX equation environment is not displayed appropriately. The following code

begin{equation}
a + b = c
end{equation}

is displayed as follows:
IMG_1927

The LaTeX code in $$ latex $$ and \[ latex \] is displayed correctly. However, I prefer to use the LaTeX equation environment for some reasons.

@amake amake mentioned this issue Apr 28, 2021
Closed
@amake
Copy link
Owner

amake commented Apr 28, 2021

@fountainer Thanks for the report. That doesn't have anything to do with this issue, so let's move the discussion to #42.

@amake
Copy link
Owner

amake commented May 4, 2021

This is implemented in v1.18.1, which is out for all platforms.

@amake amake closed this as completed May 4, 2021
amake added a commit that referenced this issue Oct 28, 2022
@amake
Fix internal Flutter error scrolling doc while width constrained
b93803a 
```
══╡ EXCEPTION CAUGHT BY SCHEDULER LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during a scheduler callback:
Layer OffsetEngineLayer was previously used as oldLayer.
Once a layer is used as oldLayer, it may not be used again. Instead, after calling one of the
SceneBuilder.push* methods and passing an oldLayer to it, use the layer returned by the method as
oldLayer in subsequent frames.
'dart:ui/compositing.dart':
Failed assertion: line 110 pos 9: '<optimized out>'

Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.md

When the exception was thrown, this was the stack:
#2      _EngineLayerWrapper._debugCheckNotUsedAsOldLayer (dart:ui/compositing.dart:110:9)
#3      SceneBuilder.addRetained.<anonymous closure>.recursivelyCheckChildrenUsedOnce (dart:ui/compositing.dart:695:21)
#4      List.forEach (dart:core-patch/growable_array.dart:416:8)
#5      SceneBuilder.addRetained.<anonymous closure>.recursivelyCheckChildrenUsedOnce (dart:ui/compositing.dart:701:18)
#6      SceneBuilder.addRetained.<anonymous closure> (dart:ui/compositing.dart:704:7)
#7      SceneBuilder.addRetained (dart:ui/compositing.dart:707:6)
#8      Layer._addToSceneWithRetainedRendering (package:flutter/src/rendering/layer.dart:671:15)
#9      ContainerLayer.addChildrenToScene (package:flutter/src/rendering/layer.dart:1284:13)
#10     OffsetLayer.addToScene (package:flutter/src/rendering/layer.dart:1421:5)
#11     Layer._addToSceneWithRetainedRendering (package:flutter/src/rendering/layer.dart:674:5)
#12     ContainerLayer.addChildrenToScene (package:flutter/src/rendering/layer.dart:1284:13)
#13     ClipRectLayer.addToScene (package:flutter/src/rendering/layer.dart:1590:5)
#14     Layer._addToSceneWithRetainedRendering (package:flutter/src/rendering/layer.dart:674:5)
#15     ContainerLayer.addChildrenToScene (package:flutter/src/rendering/layer.dart:1284:13)
#16     OffsetLayer.addToScene (package:flutter/src/rendering/layer.dart:1421:5)
#17     Layer._addToSceneWithRetainedRendering (package:flutter/src/rendering/layer.dart:674:5)
#18     ContainerLayer.addChildrenToScene (package:flutter/src/rendering/layer.dart:1284:13)
#19     OffsetLayer.addToScene (package:flutter/src/rendering/layer.dart:1421:5)
#20     Layer._addToSceneWithRetainedRendering (package:flutter/src/rendering/layer.dart:674:5)
#21     ContainerLayer.addChildrenToScene (package:flutter/src/rendering/layer.dart:1284:13)
#22     OffsetLayer.addToScene (package:flutter/src/rendering/layer.dart:1421:5)
#23     Layer._addToSceneWithRetainedRendering (package:flutter/src/rendering/layer.dart:674:5)
#24     ContainerLayer.addChildrenToScene (package:flutter/src/rendering/layer.dart:1284:13)
#25     TransformLayer.addToScene (package:flutter/src/rendering/layer.dart:1914:5)
#26     ContainerLayer.buildScene (package:flutter/src/rendering/layer.dart:1097:5)
#27     RenderView.compositeFrame (package:flutter/src/rendering/view.dart:231:37)
#28     RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:514:18)
#29     WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:869:13)
#30     RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:375:5)
#31     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1271:15)
#32     SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1200:9)
#33     SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:1058:5)
#34     _invoke (dart:ui/hooks.dart:145:13)
#35     PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:338:5)
#36     _drawFrame (dart:ui/hooks.dart:112:31)
(elided 2 frames from class _AssertionError)
════════════════════════════════════════════════════════════════════════════════════════════════════
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alensiljak @amake @fountainer