Skip to content

Commit

Permalink
fix: Change default MAX_ACTION_RUNTIME (aws-actions#103)
Browse files Browse the repository at this point in the history
use 1h instead of 6h to match AWS CLI default (as well as default `max_session_duration` for terraform `aws_iam_role` resource)
  • Loading branch information
Alexander Mancevice authored and amancevice committed Jul 31, 2020
1 parent c0243df commit b8731f4
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions index.js
Expand Up @@ -2,9 +2,8 @@ const core = require('@actions/core');
const aws = require('aws-sdk');
const assert = require('assert');

// The max time that a GitHub action is allowed to run is 6 hours.
// That seems like a reasonable default to use if no role duration is defined.
const MAX_ACTION_RUNTIME = 6 * 3600;
// The max time that a GitHub action is allowed to run is 1 hour, the same default as the AWS CLI.
const MAX_ACTION_RUNTIME = 3600;
const USER_AGENT = 'configure-aws-credentials-for-github-actions';
const MAX_TAG_VALUE_LENGTH = 256;
const SANITIZATION_CHARACTER = '_';
Expand Down

0 comments on commit b8731f4

Please sign in to comment.