Proposed fix for issue #15 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old algorithm used a "fudge factor" to deal with complete non-submissions. This unfairly favors non-submitters since it always increases their PA marks. (They receive all the same marks from peers, but now multiplied by a fudge factor that is greater than one.) This fix sets the fudge factor to one, and replaces blank submissions with straight ones. This solves the problem while not influencing either the non-submitter's marks, or the marks of their peers.
Undefined key error fixed. Corrected $total for each $memberid after replacing a non-submission with ones.
Correction for the case when $selfgrade = false. When replacing a non-submission with ones across the board, only do this for the grader too if selfgrading is active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "fudge factor" to deal with non-submission of PA marks always boosts the PA result of the non-submitter. This proposed fix responds to this by setting the fudge factor to 1, and inserting a mark of one against all other team members on behalf of someone who doesn't repsond. Issue #15 describes the problem and the fix in full detail.