-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix earcut bug - triangulating faces with +4 vertices #32
Commits on Nov 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 40385f4 - Browse repository at this point
Copy the full SHA 40385f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3feb42d - Browse repository at this point
Copy the full SHA 3feb42dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50f689b - Browse repository at this point
Copy the full SHA 50f689bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cc39c3 - Browse repository at this point
Copy the full SHA 6cc39c3View commit details
Commits on Nov 21, 2020
-
second earcut fix - since only the first two coordinates are used in …
…triangualation (even when dim=3), it is important we give it a non degenrate face.. this commit checks which coordinates have the largest variance and rearanges the dimensions accordingly. this doesnt affect the model in anyway
Configuration menu - View commit details
-
Copy full SHA for 2bbc16d - Browse repository at this point
Copy the full SHA 2bbc16dView commit details
Commits on Nov 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f5b8979 - Browse repository at this point
Copy the full SHA f5b8979View commit details
Commits on Nov 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fc84a3d - Browse repository at this point
Copy the full SHA fc84a3dView commit details -
Correct is2d and needsFlip detection and y/z flipping
* Correct is2d detection: 2D only if all vertices are 2D, and treat 0 the same as an absent third coordinate. * Always swap y and z coordinates when importing/exporting FOLD, independent of 2D status, for consistent behavior in all cases. (To get there, `rawFold` also has swapped coordiantes.) * To decide `needsFlip`, instead of looking for a face edge in the first triangle, which can fail if the first triangle is a fully interior triangle, look for the first edge of the face in all the triangles.
Configuration menu - View commit details
-
Copy full SHA for d7fb3d1 - Browse repository at this point
Copy the full SHA d7fb3d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68c9a6a - Browse repository at this point
Copy the full SHA 68c9a6aView commit details
Commits on Nov 29, 2020
-
Revert 2D -> 3D mapping instead of y/z swap
Swapping y/z flips the coordinate system between left- and right-handed, effectively reversing the notions of cw/ccw. This isn't an issue in 2D, because there it would be the same as mapping (x, y, z) → (x, -z, y) (because z=0) which doesn't flip handedness, but it's a problem in 3D.
Configuration menu - View commit details
-
Copy full SHA for ff66566 - Browse repository at this point
Copy the full SHA ff66566View commit details -
earcut sometimes returns less triangles than needed to cover the face…
… (because of it using only the first two coordinates, and possible degeneracies there). this update makes sure there are at least enough triangles before breaking
Configuration menu - View commit details
-
Copy full SHA for 940b2e0 - Browse repository at this point
Copy the full SHA 940b2e0View commit details
Commits on Nov 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 18a0313 - Browse repository at this point
Copy the full SHA 18a0313View commit details