Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Prevent enter submit message #93

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

MarceloZapatta
Copy link
Contributor

Hi!

This is a fix for: #75

Prevent default enter submit message. Instead insert a line break.

Control+Enter is the replace for send message.

@amanharwara
Copy link
Owner

This works perfectly. I think it would make sense to make this toggle-able. Let me know if that's possible. If it's not, I'll just merge it how it is currently.

@amanharwara amanharwara self-assigned this Oct 2, 2020
@amanharwara amanharwara linked an issue Oct 2, 2020 that may be closed by this pull request
@MarceloZapatta
Copy link
Contributor Author

@amanharwara Yes, make sense and is possible, implemented in the last commit.

Copy link
Owner

@amanharwara amanharwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. I'll merge it. Thanks for the help!

@amanharwara amanharwara merged commit ff02fde into amanharwara:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Return" sends message immediately without warning
2 participants