Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.5 doesn't compile on Rust 1.57 #46

Closed
jcrevier opened this issue Feb 9, 2023 · 3 comments
Closed

1.1.5 doesn't compile on Rust 1.57 #46

jcrevier opened this issue Feb 9, 2023 · 3 comments

Comments

@jcrevier
Copy link

jcrevier commented Feb 9, 2023

Attempting to compile thread local on Rust 1.57 results in the following compiler error:

error[E0658]: use of unstable library feature 'thread_local_const_init'
   --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/thread_local-1.1.5/src/thread_id.rs:130:9
    |
130 |         thread_local! { static THREAD: Cell<Option<Thread>> = const { Cell::new(None) }; }
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #84223 <https://github.com/rust-lang/rust/issues/84223> for more information
    = note: this error originates in the macro `$crate::__thread_local_inner` (in Nightly builds, run with -Z macro-backtrace for more info)
For more information about this error, try `rustc --explain E0658`.
error: could not compile `thread_local` due to previous error

Not sure if this was intentional change to the MSRV or not. The README lists the MSRV as 1.36.0.

@Amanieu
Copy link
Owner

Amanieu commented Feb 9, 2023

1.1.5 has been yanked due to another issue.

@jcrevier jcrevier closed this as completed Feb 9, 2023
@jcrevier
Copy link
Author

jcrevier commented Feb 9, 2023

Closing as 1.1.5 has been yanked.

@Amanieu
Copy link
Owner

Amanieu commented Feb 10, 2023

FYI the MSRV will be bumped to 1.59, which was released 11 months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants