Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add an option "validateSingleCommitMatchesPr" for #159 #160

Merged
merged 3 commits into from
Feb 8, 2022
Merged

feat: add an option "validateSingleCommitMatchesPr" for #159 #160

merged 3 commits into from
Feb 8, 2022

Conversation

kenji-miyake
Copy link
Contributor

Resolves #159

feat: add an option "validateSingleCommitMatchesPr" for amannn#159
56fd738 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake changed the title feat: add an option "validateSingleCommitMatchesPr" for #159 feat: add an option "validateSingleCommitMatchesPr" for #159 (edit for testing) Feb 7, 2022
@kenji-miyake
Copy link
Contributor Author

Failed as expected.
https://github.com/amannn/action-semantic-pull-request/runs/5095017507?check_suite_focus=true#step:6:8

Error: The pull request has only one (non-merge) commit and in this case Github will use it as the default commit message when merging. The pull request title doesn't match the commit though ("feat: add an option "validateSingleCommitMatchesPr" for #159 (edit for testing)" vs. "feat: add an option "validateSingleCommitMatchesPr" for #159"). Please update the pull request title accordingly to avoid surprises.

@kenji-miyake kenji-miyake changed the title feat: add an option "validateSingleCommitMatchesPr" for #159 (edit for testing) feat: add an option "validateSingleCommitMatchesPr" for #159 Feb 7, 2022
@kenji-miyake
Copy link
Contributor Author

@amannn cc @mowies I think it's ready. could you review it? 🙏

rename to validateSingleCommitMatchesPrTitle
81e4c84 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
mowies
mowies approved these changes Feb 7, 2022
View reviewed changes
Copy link

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amannn
amannn reviewed Feb 8, 2022
View reviewed changes
Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this @kenji-miyake!

README.md Outdated Show resolved Hide resolved
@kenji-miyake @amannn
Update descriptions in README.md and action.yml
c101b57 
Co-authored-by: Jan Amann <jan@amann.me>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake force-pushed the add-validateSingleCommitMatchesPr branch from afbb618 to c101b57 Compare February 8, 2022 07:32
@amannn amannn merged commit c05e358 into amannn:master Feb 8, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kenji-miyake kenji-miyake deleted the add-validateSingleCommitMatchesPr branch February 8, 2022 09:14
@kenji-miyake kenji-miyake mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies approved these changes

@amannn amannn Awaiting requested review from amannn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make new single-commit PR validation optional
3 participants
@kenji-miyake @amannn @mowies