Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make link in error clickable in GH Actions #112

Merged
merged 2 commits into from Jul 26, 2021
Merged

fix: Make link in error clickable in GH Actions #112

merged 2 commits into from Jul 26, 2021

Conversation

@dcroote
Copy link
Contributor

@dcroote dcroote commented Jul 13, 2021

For PRs that fail due to the error "No release type found in pull request title", the resulting GH Actions log message link to https://www.conventionalcommits.org/ erroneously includes the closing parenthesis that results in a Page Not Found error when the link is clicked. For example, see this job in the public rust-bio repo.

This PR adjusts the error message text to remove the parentheses and thereby make the link point to the correct location. See here for the job output of a mock PR in a mock repo that uses my forked workflow with the change.

Copy link
Owner

@amannn amannn left a comment

Thanks a lot for your contribution!

I have just a minor comment, but other than that this is good to go.

src/validatePrTitle.js Outdated Show resolved Hide resolved
Co-authored-by: Jan Amann <jan@amann.me>
@dcroote
Copy link
Contributor Author

@dcroote dcroote commented Jul 26, 2021

Great, thanks. I agree it makes sense to be on the safe side by removing the trailing period.

@amannn amannn merged commit 2a292a6 into amannn:master Jul 26, 2021
3 checks passed
@github-actions
Copy link

@github-actions github-actions bot commented Jul 26, 2021

🎉 This PR is included in version 3.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dcroote dcroote deleted the error-link branch Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants