Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale is reseted from selected to accept-language's locale when localePrefix is 'never' #811

Closed
aleeghb opened this issue Jan 24, 2024 · 1 comment · Fixed by #817
Closed
Labels
bug Something isn't working

Comments

@aleeghb
Copy link

aleeghb commented Jan 24, 2024

Description

When user navigates from external site to our site then locale is reseted to accept-language's locale because NEXT_LOCALE cookie has a SameSite: Strict and browser don't send cookie in this case. Also localePrefix is never and thats why next-intl set locale to accept-language's locale (or to default locale).

This is not reproducible if Lax is used.

Mandatory reproduction URL (CodeSandbox or GitHub repository)

Reproduction description

I can't give you reproduction example, I've tried but it's not working (basic functional). Unfortunately, I don't have time to figure out why.

Expected behaviour

Shouldn't reset the locale.

@aleeghb aleeghb added bug Something isn't working unconfirmed Needs triage. labels Jan 24, 2024
@amannn
Copy link
Owner

amannn commented Jan 25, 2024

Yep, this is correct, thanks for the report! Will be fixed in #817.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants