Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove / from thermal conductivity units in input spec #49

Closed
ecoon opened this issue Jul 30, 2020 · 2 comments
Closed

Remove / from thermal conductivity units in input spec #49

ecoon opened this issue Jul 30, 2020 · 2 comments
Assignees

Comments

@ecoon
Copy link
Collaborator

ecoon commented Jul 30, 2020

Slashes in input spec parameter names break some xml parsers, at least in python, and need to be escaped. This makes them hard to work with for external tools, even though they are valid in C++/Teuchos::ParameterList.

Currently the only ones I know of are in the thermal conductivity parameters: [W/(m-K)] units, which should get changed to [W m^-1 K^-1]

@ecoon ecoon self-assigned this Jul 30, 2020
@lipnikov
Copy link
Contributor

I am curious, what is a need to specify SI units explicitly?

@ecoon
Copy link
Collaborator Author

ecoon commented Jul 30, 2020

Just for user documentation. In native spec we don't have the ability to introduce a "units=XXX" to our Parameter object, and not having units in input files that get read by users means our users make mistakes and assume incorrect units.

@ecoon ecoon closed this as completed in 1a107ae Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants