Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the top level scope a name to fix vcd file production #23

Closed
nmigen-issue-migration opened this issue Jan 6, 2019 · 1 comment
Closed

Comments

@nmigen-issue-migration
Copy link

Issue by adamgreig
Sunday Jan 06, 2019 at 00:09 GMT
Originally opened as m-labs/nmigen#21


At present the root_fragment in the pysim hierarchy has an empty scope=(), and when this is added to the vcd file we get:

$scope module  $end

i.e. the top-level module has no name. This breaks gtkwave somewhat as you can't re-select the top level after selecting a submodule:

image

This patch sets the root_fragment's scope to "top", producing a vcd with a useful hierarchy:

image

I can't see an obvious way to get a more useful name than "top" for the root fragment, but if one exists that would be even better.


adamgreig included the following code: https://github.com/m-labs/nmigen/pull/21/commits

@nmigen-issue-migration
Copy link
Author

Comment by whitequark
Sunday Jan 06, 2019 at 00:10 GMT


This breaks gtkwave somewhat as you can't re-select the top level after selecting a submodule:

Actually, you can. Click on e.g. rdport again after selecting it. But I guess your solution is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant