Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video native control show up after quitting PiP mode #6

Closed
choco opened this issue May 2, 2017 · 2 comments
Closed

Video native control show up after quitting PiP mode #6

choco opened this issue May 2, 2017 · 2 comments
Labels

Comments

@choco
Copy link

choco commented May 2, 2017

As the title says, once I get out of PiP mode, the native controls of the video elements become visible (the ones that you would see if the player doesn't provide custom ones). Would it be possible to keep them hidden?

EDIT:
Added a screenshot that shows what I mean
screen shot 2017-05-03 at 01 13 35

@amarcu5
Copy link
Owner

amarcu5 commented May 4, 2017

Appreciate the report, this is actually a bug in the latest Safari Technology Preview. In case it doesn't get fixed before public release I've come up with a quick workaround:

     const presentationMode = 'inline' === video.webkitPresentationMode ? 'picture-in-picture' : 'inline';
     video.webkitSetPresentationMode(presentationMode);
+    
+    video.controls = true;
+    video.controls = false;
   });
 
   const referenceNode = currentResource.buttonInsertBefore ? currentResource.buttonInsertBefore(parent) : null;

@amarcu5 amarcu5 added the bug label May 4, 2017
@amarcu5
Copy link
Owner

amarcu5 commented Jun 12, 2017

Bug appears to be fixed in the latest release (32) of the Safari Technology Preview

@amarcu5 amarcu5 closed this as completed Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants