Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UmaMusumeLibrary.json #75

Closed
wants to merge 1 commit into from
Closed

Conversation

trium-v
Copy link

@trium-v trium-v commented Aug 20, 2021

fix typo

amate added a commit that referenced this pull request Aug 31, 2021
・[add] レース一覧に、予約レースまでのターン数表示を追加 #74
・[fix] フジキセキの二つ名のtypo修正 #75
・[update] UmaMusumeLibrary.json更新
- キャラ
【吉兆・初あらし】マチカネフクキタル
- サポート
[徹底管理主義]樫本理子
[幸せは曲がり角の向こう]ライスシャワー
@amate
Copy link
Owner

amate commented Aug 31, 2021

修正しました
thx!

@amate amate closed this Aug 31, 2021
@starg09
Copy link
Contributor

starg09 commented Oct 15, 2021

Fixed

Seems this fix wasn't merged/commited after all? Looking at the git blame, last change to the line on master was July 12, with the typo still present.

@amate
Copy link
Owner

amate commented Oct 15, 2021

The typo has been fixed in v1.14
https://github.com/amate/UmaUmaCruise/blob/673b4e06c1c26bfa22ff565b9f3b6dc777244c55/UmaLibrary/UmaMusumeLibrary_v2.json

If you don't see any updates, it's because your forked repository stopped updating two months ago.
https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@starg09
Copy link
Contributor

starg09 commented Oct 15, 2021

The typo has been fixed in v1.14 https://github.com/amate/UmaUmaCruise/blob/673b4e06c1c26bfa22ff565b9f3b6dc777244c55/UmaLibrary/UmaMusumeLibrary_v2.json

Oh, I was looking at the wrong repo when reporting! Sorry for the unneeded ping 😖

That was just for linking inside github, I had noticed "the typo" independently on what I thought to be a clean installation of 1.14 (the compiled release). But I must have done something weird, as I can see everything fixed as you mention; both on the downloaded zip and when updating UmaMusumeLibrary.json through the settings menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants