Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixerIO deprecated API #31

Closed
kf-nz opened this issue Jun 6, 2018 · 8 comments
Closed

FixerIO deprecated API #31

kf-nz opened this issue Jun 6, 2018 · 8 comments

Comments

@kf-nz
Copy link

kf-nz commented Jun 6, 2018

The fixer.io API endpoint has been deprecated, and API keys are now required for the new one.

I was wondering if you have any plans to update this client?

https://github.com/fixerAPI/fixer

@amatellanes
Copy link
Owner

Hi @aetolus,

Yes... I'm planning to update to the new endpoint. At least I'd like to update those endpoints you can use with a free API key as soon as possible.

Thanks for your interest!

@kf-nz
Copy link
Author

kf-nz commented Jun 6, 2018

Thanks @amatellanes, very helpful!

@fabaff
Copy link

fabaff commented Jun 10, 2018

Is there an ETA on those changes? We are using this module in Home Assistant (home-assistant/core#14911).

@amatellanes
Copy link
Owner

Hi @fabaff,

I'm currently working on that in this branch. I hope to release a new version to support new Fixer endpoint this week... My initial ideal is that this new package version will support Free Plan.

@fabaff
Copy link

fabaff commented Jun 11, 2018

Awesome, thanks for the feedback.

Good idea to start with the Free plan. I guess that most people will stick to that. It's sad to see that they only support SSL/TLS for the other plans which will require additional work for all third-party tools.

@fabaff
Copy link

fabaff commented Jun 11, 2018

Just two quick comments for your branch:

  • You don't need to test this. The access/api key is now a requirement.
  • It would be nice if you could add a timeout to the requests (e.g., here)

@amatellanes
Copy link
Owner

Thanks for the comments @fabaff !

My initial idea about this was using a different API Key from constructor when calling a method... but maybe I'd better remove it for simplicity's sake and perhaps add it in the future.

@amatellanes
Copy link
Owner

Version 1.0.0a0 available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants