Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow maxlength validation for inputs which can be blank #20

Merged
merged 1 commit into from
Jan 5, 2016

Conversation

kv109
Copy link
Contributor

@kv109 kv109 commented Nov 6, 2015

Before:

validates :company_url, allow_blank: true, length: { maximum: 255 }

was translated to:

<input type="url" name="company[company_url]" id="company_company_url" />

Now it's translated to:

<input maxlength="255" size="255" type="url" name="company[company_url]" id="company_company_url" />

amatsuda added a commit that referenced this pull request Jan 5, 2016
allow maxlength validation for inputs which can be blank
@amatsuda amatsuda merged commit 4e368e6 into amatsuda:master Jan 5, 2016
@amatsuda
Copy link
Owner

amatsuda commented Jan 5, 2016

@kv109 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants