Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoring routes or actions #20

Merged
merged 11 commits into from Jan 8, 2018
Merged

Conversation

distributedlife
Copy link
Contributor

Added support for a .traceroute, .traceroute.yml or .traceroute.yaml file. If it's found in the root directory then it'll read the file in and add the ignore regexes to the array of routes/actions to ignore.

I've added some doco to the readme. Tests are included.

@lowjoel
Copy link

lowjoel commented May 19, 2015

👍

1 similar comment
@misteral
Copy link

misteral commented Oct 3, 2015

👍

@MehdiK
Copy link

MehdiK commented Feb 29, 2016

Is there any chance you can merge this PR and release it please? We have been pointing to the GitHub url from our project and just want to point to the gem. Thanks.

@@ -25,7 +26,7 @@ def defined_action_methods
controller.action_methods.reject {|a| (a =~ /\A(_conditional)?_callback_/) || (a == '_layout_from_proc')}.map do |action|
"#{controller.controller_path}##{action}"
end
end.flatten.reject {|r| r.start_with? 'rails/'}
end.flatten.reject {|r| @ingored_unreachable_actions.any? { |m| r.match(m) } }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is probably a typo ignored instead ingored

@piotr-galas
Copy link

What about this pr? I can help fix it if somebody will merge it.

@StephanMeijer
Copy link

Please. Merge.

@amatsuda amatsuda merged commit 94eb4e6 into amatsuda:master Jan 8, 2018
@amatsuda
Copy link
Owner

Just published 0.6.0 gem with this feature.
But TBH I'm doubting if you guys still need this feature.

Another big feature intruduced in 0.6.0, Rails Engines support, would totally cover your Jasmine or other mounted Engines use case, so I guess most of you who showed up in this thread might not in fact need to deal with the YAML file thing.

Anyway, sorry for letting you wait so long, and please enjoy the new gem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants