You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently x-robots-header-development.conf defines $lagoon_environment_type. This makes the variable also available for other configs.
To make this more clear I suggest to move the variable declaration to its own file like _lagoon_environment_type.conf. I'm using an underscore here to ensure that file is loaded first via the current include rules ( include /etc/nginx/helpers/*.conf;). An alternative would be to use numbered prefixes like 00_lagoon_environment_type.conf, 10_x-robots-header-development.conf, ….
The text was updated successfully, but these errors were encountered:
we actually refactored nginx to use openresty which provides LUA, with this we can now use actual LUA scripts which are superior to the nginx ifs.
With that we're also setting the variable here via LUA: #748
I do agree though that the order of the helpers are important, so I have another PR which changes them to be prefixed with numbers: #760
Currently
x-robots-header-development.conf
defines$lagoon_environment_type
. This makes the variable also available for other configs.To make this more clear I suggest to move the variable declaration to its own file like
_lagoon_environment_type.conf
. I'm using an underscore here to ensure that file is loaded first via the current include rules (include /etc/nginx/helpers/*.conf;
). An alternative would be to use numbered prefixes like00_lagoon_environment_type.conf
,10_x-robots-header-development.conf
, ….The text was updated successfully, but these errors were encountered: