Allow dashboard log container to be "full height" #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When viewing deployment logs in the dashboard, the logs are typically very long, but the log window is limited to 600px heigh. Given there is nothing else on the deployment page other than the logs, would be good if the height wasn't limited. There's a few benefits to this: 1. Users don't have to scroll as much because more of the log output fits on their screen at once. 1. Once the container is not-height restricted, the browser's behaviour of showing where search matches occur in the document by flagging them on the its scroll bar kicks in, this is great for jumping between areas areas of the output where a search string exists.
rocketeerbkw
requested changes
Apr 30, 2019
Addresses comment: #1065 (review) Log viewer should have a min-height so that it's longer than the left hand navigation.
|
Yep, PR updated to change it to |
tobybellwood
pushed a commit
to uselagoon/lagoon-ui
that referenced
this pull request
Aug 5, 2021
Addresses comment: uselagoon/lagoon#1065 (review) Log viewer should have a min-height so that it's longer than the left hand navigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1064
See: https://www.govcms.support/support/tickets/2073
Checklist
Changelog Entry
Change - Remove the 600px hight limit for the logs container in the deployment section of the dashboard, this allows the container to be full height #1064
Closing issues
Closes #1064