Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashboard log container to be "full height" #1065

Merged
merged 2 commits into from May 27, 2019

Conversation

Projects
None yet
3 participants
@Feng-Shui
Copy link
Contributor

commented Apr 30, 2019

PR for #1064

See: https://www.govcms.support/support/tickets/2073

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Changelog Entry

Change - Remove the 600px hight limit for the logs container in the deployment section of the dashboard, this allows the container to be full height #1064

Closing issues

Closes #1064

Allow log container to be full height
When viewing deployment logs in the dashboard, the logs are typically very long, but the log window is limited to 600px heigh.  Given there is nothing else on the deployment page other than the logs, would be good if the height wasn't limited.

There's a few benefits to this:

1. Users don't have to scroll as much because more of the log output fits on their screen at once.
1. Once the container is not-height restricted, the browser's behaviour of showing where search matches occur in the document by flagging them on the its scroll bar kicks in, this is great for jumping between areas areas of the output where a search string exists.
@rocketeerbkw
Copy link
Member

left a comment

Can you change this to min-height instead? I think the left sidebar area doesn't handle the main content area being very short well (in the case where logs are not available).

Set min height for left hand nav.
Addresses comment: #1065 (review)

Log viewer should have a min-height so that it's longer than the left hand navigation.
@Feng-Shui

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Yep, PR updated to change it to min-height: 600px.

@rocketeerbkw
Copy link
Member

left a comment

Thanks!

@Schnitzel Schnitzel added this to the v0.23.0 milestone May 27, 2019

@Schnitzel Schnitzel merged commit db9ee72 into amazeeio:master May 27, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.