Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashboard log container to be "full height" #1065

Merged
merged 2 commits into from May 27, 2019
Merged

Allow dashboard log container to be "full height" #1065

merged 2 commits into from May 27, 2019

Commits on Apr 30, 2019

  1. Allow log container to be full height

    When viewing deployment logs in the dashboard, the logs are typically very long, but the log window is limited to 600px heigh.  Given there is nothing else on the deployment page other than the logs, would be good if the height wasn't limited.
    
    There's a few benefits to this:
    
    1. Users don't have to scroll as much because more of the log output fits on their screen at once.
    1. Once the container is not-height restricted, the browser's behaviour of showing where search matches occur in the document by flagging them on the its scroll bar kicks in, this is great for jumping between areas areas of the output where a search string exists.
    Feng-Shui committed Apr 30, 2019
    Copy the full SHA
    013aea5 View commit details
    Browse the repository at this point in the history
  2. Set min height for left hand nav.

    Addresses comment: #1065 (review)
    
    Log viewer should have a min-height so that it's longer than the left hand navigation.
    Feng-Shui committed Apr 30, 2019
    Copy the full SHA
    4c68628 View commit details
    Browse the repository at this point in the history