Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve storage-calculator script add update to support oc 3.9. #1291

Merged
merged 3 commits into from Nov 26, 2019

Conversation

@thom8
Copy link
Member

thom8 commented Oct 11, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Adds a check for a valid namespace before deploying storage-calc to avoid script failures when an environment doesn't exist.

Updates references to oc volume as this has changes to oc set volume in oc 3.9

**Includes PR 1158 - Update version of oc used in oc image

Changelog Entry

Improvement - Improve storage-calculator script add update to support for oc 3.9. (#1290)

Closing issues

closes #1290

@thom8 thom8 force-pushed the thom8:storage-calc-oc-3.9 branch 2 times, most recently from f138d39 to 2a3fb9d Nov 12, 2019
@Schnitzel Schnitzel added this to the v1.2.0 milestone Nov 18, 2019
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Nov 20, 2019

@thom8 we have now oc 3.11 in here: #1158
can you update your code so that it doesn't try to update the OC anymore?

@thom8

This comment has been minimized.

Copy link
Member Author

thom8 commented Nov 21, 2019

thanks @tobybellwood!

@thom8 thom8 force-pushed the thom8:storage-calc-oc-3.9 branch from 46ec0f3 to 7b6c493 Nov 26, 2019
@Schnitzel Schnitzel merged commit bf42c48 into amazeeio:master Nov 26, 2019
1 check was pending
1 check was pending
continuous-integration/jenkins/pr-merge This commit is being built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.