Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documented XDEBUG variable name #1507

Merged
merged 1 commit into from Feb 4, 2020
Merged

Fix typo in documented XDEBUG variable name #1507

merged 1 commit into from Feb 4, 2020

Conversation

@smlx
Copy link
Contributor

smlx commented Dec 19, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The documented name of the variable to enable xdebug has a typo.

Changelog Entry

n/a

Closing issues

n/a

@smlx

This comment has been minimized.

Copy link
Contributor Author

smlx commented Dec 19, 2019

The alternative is to change the xdebug entrypoint script logic, but I thought it may break peoples existing environments..?

Copy link
Contributor

tobybellwood left a comment

simple docco change - XDEBUG_ENABLE is used in all cli/fpm entrypoints and dockerfiles

@smlx smlx force-pushed the xdebug-enable branch from 232dd94 to 1341a02 Jan 8, 2020
@smlx smlx force-pushed the xdebug-enable branch from 1341a02 to 0c554c0 Jan 20, 2020
@smlx smlx force-pushed the xdebug-enable branch from 0c554c0 to f88ce7e Jan 22, 2020
@tobybellwood tobybellwood added this to the v1.3.0 milestone Feb 4, 2020
@Schnitzel Schnitzel merged commit d483ef5 into master Feb 4, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@smlx smlx deleted the xdebug-enable branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.