Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in documented XDEBUG variable name #1507

Merged
merged 1 commit into from Feb 4, 2020
Merged

Fix typo in documented XDEBUG variable name #1507

merged 1 commit into from Feb 4, 2020

Conversation

smlx
Copy link
Member

@smlx smlx commented Dec 19, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The documented name of the variable to enable xdebug has a typo.

Changelog Entry

n/a

Closing issues

n/a

@smlx smlx mentioned this pull request Nov 10, 2022
Open
@smlx
Copy link
Member Author

smlx commented Dec 19, 2019 •
edited

The alternative is to change the xdebug entrypoint script logic, but I thought it may break peoples existing environments..?

@tobybellwood tobybellwood added the 7-documentation-examples Documentation & Examples / DX subsystem label Dec 19, 2019
tobybellwood
tobybellwood approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple docco change - XDEBUG_ENABLE is used in all cli/fpm entrypoints and dockerfiles

@tobybellwood tobybellwood added this to the v1.3.0 milestone Feb 4, 2020
@Schnitzel Schnitzel merged commit d483ef5 into master Feb 4, 2020
@smlx smlx deleted the xdebug-enable branch February 5, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
7-documentation-examples Documentation & Examples / DX subsystem
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smlx @tobybellwood @Schnitzel