Add newrelic to api #1983
Merged
Add newrelic to api #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlevi
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
In an effort to get more info into performance issues (see #1908) this PR adds new relic tracking support to the API. We offer it to our amazee.io customers, may as well take advantage of it ourselves too!
This initial work is very basic. SQL tracing is only supported out of the box with the mysql/mysql2 packages. That's different than our planned switch to mariadb (#1270). There is no OOTB support for apollo/graphql, so the only data we currently get is timing info.
Instrumenting of external requests (keycloak) also looks to be somewhat bare at this time.
To enable in production, add an environment variable
NEW_RELIC_LICENSE_KEYClosing issues
n/a