Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nslookup returns non-zero error code on 'host.docker.internal' #2002

Merged
merged 3 commits into from Jul 10, 2020

Conversation

rocketeerbkw
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Fixes nslookup returning a non-zero error code when checking host.docker.internal

[drupal-example]php:/app$ nslookup host.docker.internal
Server:		127.0.0.11
Address:	127.0.0.11:53

Non-authoritative answer:
Name:	host.docker.internal
Address: 192.168.65.2

** server can't find host.docker.internal: NXDOMAIN

[drupal-example]php:/app$ echo $?
1
[drupal-example]php:/app$ nslookup -query=A host.docker.internal
Server:		127.0.0.11
Address:	127.0.0.11:53

Non-authoritative answer:
Name:	host.docker.internal
Address: 192.168.65.2

[drupal-example]php:/app$ echo $?
0

Closing issues

closes #1088

@Schnitzel Schnitzel added this to the v1.8.0 milestone Jul 9, 2020
@Schnitzel Schnitzel added the 6-images-testing Base Images & Testing subsystem label Jul 9, 2020
@Schnitzel Schnitzel merged commit 2c4a274 into master Jul 10, 2020
@tobybellwood tobybellwood deleted the 1088-xdebug-wrong-host branch September 10, 2020 06:15
@iijiang iijiang mentioned this pull request Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xdebug host is not discovered correctly
2 participants