Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual brand/logo link switch #105

Closed
jossemarGT opened this issue Oct 9, 2021 · 1 comment · Fixed by #106
Closed

Multilingual brand/logo link switch #105

jossemarGT opened this issue Oct 9, 2021 · 1 comment · Fixed by #106
Labels
bug Something isn't working

Comments

@jossemarGT
Copy link
Contributor

jossemarGT commented Oct 9, 2021

Hi @AmazingRise!

I am doing my local testing to migrate from Beatiful hugo theme into yours.

I found that diary does not "auto-magic-ally" set the home link in the brand/logo area when you are browsing on any other languange that is not the main one. What I mean is, when I browse mysite.com/es (second language) the brand area link still points into mysite.com instead of the languange's home.

My questions are:

  • If I want to fix it locally, should it put it under /layouts? If so what is the template/partial name I should look like? I think those are the sidebar and mobile-header partial templates so I will give them a try.
  • In case I find a solution, do you have appettite for a pull request for that?

Thank you very much in advance.

@jossemarGT
Copy link
Contributor Author

I hope you see #106 fine. The change was trivial and it does not broke my local environment, but still I would like to have your input whenever you have the time.

Thanks again for this awesome theme, I just love it :)

@AmazingRise AmazingRise added the bug Something isn't working label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants