Merge pull request #152 from trulia/feature/adding_imagePullsecret_op…

…tion_helm adding image.pullSecret option
amazon-archives · Jan 8, 2019 · a519d69 · a519d69
2 parents 9fcf5ca + 932d08e
commit a519d69
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/charts/aws-service-operator/Chart.yaml b/charts/aws-service-operator/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v1
 name: aws-service-operator
-version: 0.0.1
+version: 0.0.2
 description: The AWS Service Operator allows you to manage AWS resources using Kubernetes Custom Resource Definitions.
 keywords:
   - AWS

diff --git a/charts/aws-service-operator/README.md b/charts/aws-service-operator/README.md
@@ -24,6 +24,7 @@ The following table lists the configurable parameters of the aws-service-operato
 | `image.repository`        | Container image repository             | `awsserviceoperator/aws-service-operator`          |
 | `image.tag`               | Container image tag                    | `v0.0.1-alpha2`                                    |
 | `image.pullPolicy`        | Container pull policy                  | `IfNotPresent`                                     |
+| `image.pullSecret`        | Container pull secret (secret created not by this chart) | ``                               |
 | `operator.accountId`      | AWS Account ID to operator on          | `""`                                               |
 | `operator.bucket`         | Base bucket to store resources in      | `aws-operator`                                     |
 | `operator.clusterName`    | Used to label generated CF templates   | `aws-operator`                                     |

diff --git a/charts/aws-service-operator/templates/deployment.yaml b/charts/aws-service-operator/templates/deployment.yaml
@@ -22,6 +22,10 @@ spec:
       nodeSelector:
 {{ toYaml .Values.nodeSelector | indent 8 }}
       {{ end }}
+      {{- if .Values.image.pullSecret }}
+      imagePullSecrets:
+        - name: {{ .Values.image.pullSecret }}
+      {{- end  }}
       serviceAccountName: {{ if .Values.rbac.create }}{{ template "aws-service-operator.fullname" . }}{{ else }}"{{ .Values.rbac.serviceAccountName }}"{{ end }}
       containers:
         - name: aws-service-operator

diff --git a/charts/aws-service-operator/values.yaml b/charts/aws-service-operator/values.yaml
@@ -5,6 +5,7 @@ image:
   repository: awsserviceoperator/aws-service-operator
   tag: v0.0.1-alpha2
   pullPolicy: IfNotPresent
+  #pullSecret: your-k8-secet-to-use (not deployed by chart, but you can reference existing one)
 
 ## App config
 operator: