Skip to content
This repository has been archived by the owner on Nov 7, 2019. It is now read-only.

Fix watching cloudformation template resources #120

Merged
merged 1 commit into from Oct 16, 2018

Conversation

tantona
Copy link
Contributor

@tantona tantona commented Oct 16, 2018

This PR fixes a bug in the default resource names passed to the --resources
command line arg. This bug caused the cft operator to not watch for changes on
the cft resource.

Signed-off-by: Alexander Tanton tantonat@amazon.com

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This PR fixes a bug in the default resource names passed to the --resources
command line arg.  This bug caused the cft operator to not watch for changes on
the cft resource.

Signed-off-by: Alexander Tanton <tantonat@amazon.com>
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that issue. lgtm :shipit:

@christopherhein christopherhein added lgtm PR is ready to be merged approved PRs that are approved labels Oct 16, 2018
@tantona tantona merged commit 75b62ca into master Oct 16, 2018
@tantona tantona deleted the fix-watch-cloudformationtemplate branch October 16, 2018 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PRs that are approved lgtm PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants