This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
expose prometheus metrics endpoint #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- expose simple metrics via promhttp handler at /metrics - move operator and metrics handler into goroutines Signed-off-by: Chris Krough <ckkrough@amazon.com>
christopherhein
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
Awesome @ckrough thanks for adding this, approving this for now. Did you also want to implement some metrics within this PR or is the idea to open a separate with some metrics added?
christopherhein
added
lgtm
|
I suggest we merge this now, then add instrumentation as follow-on PRs. We can leave 111 open to kinda guide them. I'd like to look across the code to see where the important metrics are, implement those to set the tone for instrumenting the operator, then look to the community for the long tail evolving that. Sound good? |
|
Sounds great, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes a simple Prometheus
/metricsendpoint as part of #111. This adds the listener and exposes the default promhttp metrics. I think we should introduce further instrumentation as part of #111 after some discussion of what is important to monitor to start with, but it's worth adding this default set on it's own.Issue #, if available: #111
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.