This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Single Queue With Multiple Topics Subscribed #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherhein
added
code-generation
|
@christopherhein couple of minor comments then 👍 |
tantona
reviewed
Oct 25, 2018
Signed-off-by: Christopher Hein <me@christopherhein.com>
Signed-off-by: Christopher Hein <me@christopherhein.com>
Signed-off-by: Christopher Hein <me@christopherhein.com>
Signed-off-by: Christopher Hein <me@christopherhein.com>
christopherhein
force-pushed
the
chore/21-single-queue
branch
from
8c06401
to
0784af1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #21
closes #103
Description of changes:
Modifies the existing SNS -> SQS Code for the CloudFormation stacks to make it use a single queue with a topic per resource instead of a Queue and Topic per resource. Thus reducing the overall goroutines necessary to run.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.