Skip to content
This repository has been archived by the owner on Nov 7, 2019. It is now read-only.

Adding elasticache #149

Merged
merged 5 commits into from Jan 20, 2019
Merged

Adding elasticache #149

merged 5 commits into from Jan 20, 2019

Conversation

sepulworld
Copy link
Contributor

@sepulworld sepulworld commented Dec 27, 2018 •
edited

Issue #, if available: #37

Description of changes:

  • addtionalResources service/ports templatized (Now takes string input that can be templatized)
  • Add elasticache (supports both memcached and redis engines and parameters)
  • Extra logging on template creation to show template file with errors

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sepulworld
Copy link
Contributor Author

sepulworld commented Dec 27, 2018 •
edited

@christopherhein this is ready to go. Feel free to test out! I split the commits into non-generated code and generated code changes.

@sepulworld sepulworld changed the title [WIP] adding elasticache Adding elasticache Dec 27, 2018
@christopherhein christopherhein self-assigned this Jan 8, 2019
@christopherhein christopherhein added the operator/elasticache ElastiCache operator package label Jan 8, 2019
christopherhein
christopherhein suggested changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight changes just for the key casing. Overall great job!

examples/elasticache_memcached.yaml Show resolved Hide resolved
examples/elasticache_memcached.yaml Outdated Show resolved Hide resolved
@sepulworld
Copy link
Contributor Author

Looks like there is a merge conflict with readme changes I added. I can either remove them or looks like you could add them in with your write access.

@christopherhein
Copy link
Contributor

Thanks @sepulworld merging, I’ll cut a release tomorrow morning for us! Great work.

@christopherhein christopherhein merged commit cee29cf into amazon-archives:master Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherhein christopherhein christopherhein approved these changes

Assignees

@christopherhein christopherhein

Labels
operator/elasticache ElastiCache operator package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sepulworld @christopherhein