Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change annealingDurationRange to a list of floats. #100

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

krneta
Copy link
Contributor

@krneta krneta commented Dec 23, 2021

Issue #, if available:

Description of changes:
It's possible for device configurations to give us a time as a fraction of a second, therefore annealingDurationRange should be a list of floats, rather than ints.

Testing done:
tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krneta krneta requested a review from a team as a code owner December 23, 2021 19:22
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #100 (a3e8ffa) into main (f656476) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines          804       804           
  Branches       179       179           
=========================================
  Hits           804       804           
Impacted Files Coverage Δ
...evice_schema/dwave/dwave_device_capabilities_v1.py 100.00% <ø> (ø)
...ma/dwave/dwave_2000Q_device_level_parameters_v1.py 100.00% <100.00%> (ø)
...wave/dwave_advantage_device_level_parameters_v1.py 100.00% <100.00%> (ø)
...evice_schema/dwave/dwave_provider_properties_v1.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f656476...a3e8ffa. Read the comment docs.

@krneta krneta merged commit 8940c7f into main Jan 3, 2022
@krneta krneta deleted the annealingDurationRange branch January 3, 2022 17:54
math411 pushed a commit that referenced this pull request Feb 27, 2022
* feature: support for StartPreserveBlock and EndPreserveBlock instructions. (#94)

* prepare release v1.3.0

* update development version to v1.3.1.dev0

* Update copyright headers (#95)

* feature: StartVerbatimBox and EndVerbatimBox (#96)

Added the StartVerbatimBox and EndVerbatimBox instructions.
The code between the start and end instructions will not be modified by
the compiler, thus delineating a "verbatim" box of code.

The astute reader will notice that this is merely a renaming of the
instructions StartVerbatimBlock and EndVerbatimBlock; this change is
marked as a feature to emphasize the incompatibility with v1.3.0.

* prepare release v1.4.0

* update development version to v1.4.1.dev0

* doc: Fix jaqcd typo in README.md (#97)

* prepare release v1.4.0.post0

* update development version to v1.4.1.dev0

* Fix: Pin pydantic and jsonschema versions (#98)

* prepare release v1.4.1

* update development version to v1.4.2.dev0

* feature: Add support for jobs (#99)

* prepare release v1.5.0

* update development version to v1.5.1.dev0

* fix: change annealingDurationRange to a list of floats. (#100)

* prepare release v1.5.1

* update development version to v1.5.2.dev0

Co-authored-by: Sergei-kag-aws <kag@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: Cody Wang <speller26@gmail.com>
Co-authored-by: Jacky Ko <60188942+kjacky@users.noreply.github.com>
Co-authored-by: Milan <30416311+krneta@users.noreply.github.com>
math411 pushed a commit that referenced this pull request Feb 27, 2022
* feature: support for StartPreserveBlock and EndPreserveBlock instructions. (#94)

* prepare release v1.3.0

* update development version to v1.3.1.dev0

* Update copyright headers (#95)

* feature: StartVerbatimBox and EndVerbatimBox (#96)

Added the StartVerbatimBox and EndVerbatimBox instructions.
The code between the start and end instructions will not be modified by
the compiler, thus delineating a "verbatim" box of code.

The astute reader will notice that this is merely a renaming of the
instructions StartVerbatimBlock and EndVerbatimBlock; this change is
marked as a feature to emphasize the incompatibility with v1.3.0.

* prepare release v1.4.0

* update development version to v1.4.1.dev0

* doc: Fix jaqcd typo in README.md (#97)

* prepare release v1.4.0.post0

* update development version to v1.4.1.dev0

* Fix: Pin pydantic and jsonschema versions (#98)

* prepare release v1.4.1

* update development version to v1.4.2.dev0

* feature: Add support for jobs (#99)

* prepare release v1.5.0

* update development version to v1.5.1.dev0

* fix: change annealingDurationRange to a list of floats. (#100)

* prepare release v1.5.1

* update development version to v1.5.2.dev0

* feature: add control-sqrt-not gate (#101)

* feature: add control-sqrt-not gate

Addint this gate makes things like CHSH circuits much more manageable off the bat.

* fix: added tests for CV gate, in line with CY/CZ gates

* fix: updated tox.ini so that unit-tests succeed

* fix: unit tests for CV gate

* fix: revert tox.ini ahead of merge.

Co-authored-by: Mark C <mc@localhost.localdomain>
Co-authored-by: Mark C <mark.carney@gruposantander.com>

* prepare release v1.6.0

* update development version to v1.6.1.dev0

Co-authored-by: Sergei-kag-aws <kag@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: Cody Wang <speller26@gmail.com>
Co-authored-by: Jacky Ko <60188942+kjacky@users.noreply.github.com>
Co-authored-by: Kshitij Chhabra <kshitijc@users.noreply.github.com>
Co-authored-by: Milan <30416311+krneta@users.noreply.github.com>
Co-authored-by: Mark C <idelta0@gmail.com>
Co-authored-by: Mark C <mc@localhost.localdomain>
Co-authored-by: Mark C <mark.carney@gruposantander.com>
math411 pushed a commit that referenced this pull request Feb 27, 2022
* feature: support for StartPreserveBlock and EndPreserveBlock instructions. (#94)

* prepare release v1.3.0

* update development version to v1.3.1.dev0

* Update copyright headers (#95)

* feature: StartVerbatimBox and EndVerbatimBox (#96)

Added the StartVerbatimBox and EndVerbatimBox instructions.
The code between the start and end instructions will not be modified by
the compiler, thus delineating a "verbatim" box of code.

The astute reader will notice that this is merely a renaming of the
instructions StartVerbatimBlock and EndVerbatimBlock; this change is
marked as a feature to emphasize the incompatibility with v1.3.0.

* prepare release v1.4.0

* update development version to v1.4.1.dev0

* doc: Fix jaqcd typo in README.md (#97)

* prepare release v1.4.0.post0

* update development version to v1.4.1.dev0

* Fix: Pin pydantic and jsonschema versions (#98)

* prepare release v1.4.1

* update development version to v1.4.2.dev0

* feature: Add support for jobs (#99)

* prepare release v1.5.0

* update development version to v1.5.1.dev0

* fix: change annealingDurationRange to a list of floats. (#100)

* prepare release v1.5.1

* update development version to v1.5.2.dev0

* feature: add control-sqrt-not gate (#101)

* feature: add control-sqrt-not gate

Addint this gate makes things like CHSH circuits much more manageable off the bat.

* fix: added tests for CV gate, in line with CY/CZ gates

* fix: updated tox.ini so that unit-tests succeed

* fix: unit tests for CV gate

* fix: revert tox.ini ahead of merge.

Co-authored-by: Mark C <mc@localhost.localdomain>
Co-authored-by: Mark C <mark.carney@gruposantander.com>

* prepare release v1.6.0

* update development version to v1.6.1.dev0

* feature: adding MultiQubitPauliChannel to ir (#103)

* change: Relax requirements from pydantic (#102)

Allow using any version from 1.8.2 to 2.0.0 (excluding). This should be a reasonable balance between stability and flexibility.

* prepare release v1.7.0

* update development version to v1.7.1.dev0

* fix: multiqubit pauli channel with multitarget (#104)

* prepare release v1.7.1

* update development version to v1.7.2.dev0

Co-authored-by: Sergei-kag-aws <kag@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: Cody Wang <speller26@gmail.com>
Co-authored-by: Jacky Ko <60188942+kjacky@users.noreply.github.com>
Co-authored-by: Kshitij Chhabra <kshitijc@users.noreply.github.com>
Co-authored-by: Milan <30416311+krneta@users.noreply.github.com>
Co-authored-by: Mark C <idelta0@gmail.com>
Co-authored-by: Mark C <mc@localhost.localdomain>
Co-authored-by: Mark C <mark.carney@gruposantander.com>
Co-authored-by: mbeach-aws <85963088+mbeach-aws@users.noreply.github.com>
Co-authored-by: Or Ostrovsky <93072774+orclassiq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants