Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove oq3_program_result #115

Closed

Conversation

ajberdy
Copy link
Contributor

@ajberdy ajberdy commented Jul 27, 2022

Issue #, if available:

Description of changes:

This model is vestigial and not used by the final simulator

Testing done:

tox still passes

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajberdy ajberdy requested a review from jheckey July 27, 2022 22:41
@ajberdy ajberdy requested a review from a team as a code owner July 27, 2022 22:41
@ajberdy
Copy link
Contributor Author

ajberdy commented Jul 27, 2022

Though it's not currently used in the service, electing to keep the model as part of our schemas.

@ajberdy ajberdy closed this Jul 27, 2022
@ajberdy ajberdy deleted the remove-oq3-program-result branch August 23, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant