Omit MultiLineBuilder variable if empty #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayPolanco
previously approved these changes
Sep 28, 2023
sky333999
previously approved these changes
Sep 28, 2023
SaxyPandaBear
previously approved these changes
Sep 28, 2023
adam-mateen
previously approved these changes
Sep 28, 2023
zhihonl
dismissed stale reviews from adam-mateen, SaxyPandaBear, sky333999, and JayPolanco
via
f0ae37c
sky333999
approved these changes
Sep 28, 2023
JayPolanco
approved these changes
Sep 28, 2023
lisguo
pushed a commit
to lisguo/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Upstream added a new variable
MultiLineBuilderwhich was originally part of theMultilinevariable that will be omitted if empty. SinceMultiLineBuilderis a func type, yaml encoder cannot marshal it thus causing issues when creating the yaml file.Testing:
Relying on unit test. Also tested on agent side.