Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal/aws/proxy] Fix proxy server unit test. #177

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jefchien
Copy link

@jefchien jefchien commented Mar 1, 2024

Description: A previous PR (#174) unified the AWS session creation so the proxy uses the internal/aws/awsutil package. The unit tests could not be run at the time.

Testing: Ran the unit tests locally.

@jefchien jefchien requested a review from mxiamxia as a code owner March 1, 2024 19:36
Copy link

@okankoAMZ okankoAMZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! makes sense

@jefchien jefchien merged commit 622200a into aws-cwa-dev Mar 1, 2024
56 of 58 checks passed
@jefchien jefchien deleted the fix-proxy-test branch March 1, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants