Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async cluster: reconnect after full disconnect. #100

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

nihohit
Copy link

@nihohit nihohit commented Jan 14, 2024

Issue #, if available:
aws/glide-for-redis#791

Description of changes:
After the async cluster receives a ConnectionNotFound error, it means
that the cluster has no working connections, and can't refresh slots. In
such a situation the cluster will try to reconnect to the initial nodes
provided by the user, and afterwards refresh slots.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This will allow us to early reject functions that assume that
connections exist.
@ikolomi
Copy link

ikolomi commented Jan 17, 2024

Probably type in commit msg: "After the async cluster receives a ..." - async client?

After the async cluster connection receives a `ConnectionNotFound`
error, it means that the cluster has no working connections, and can't
refresh slots. In such a situation the cluster will try to reconnect to
the initial nodes provided by the user, and afterwards refresh slots.
@shachlanAmazon shachlanAmazon merged commit 38777d8 into amazon-contributing:main Jan 17, 2024
10 checks passed
@nihohit nihohit deleted the reconnect branch January 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants