https://github.com/redis-rs/redis-rs/pull/888 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
approved these changes
Jul 17, 2023
| Some(ResponsePolicy::Special) | None => { | ||
| // This is our assumption - if there's no coherent way to aggregate the responses, we just map each response to the sender, and pass it to the user. | ||
| // TODO - once RESP3 is merged, return a map value here. | ||
| future::try_join_all(connections.into_iter().map(|(addr, conn)| async move { |
There was a problem hiding this comment.
try_join_all => us join_all, when mapping we can allow some requests to succeed and others to fail
There was a problem hiding this comment.
This doesn't work without ValueError. Added TODO
| @@ -533,64 +534,116 @@ where | |||
| Ok(()) | |||
| } | |||
|
|
|||
| async fn execute_on_all_nodes( | |||
| async fn execute_on_multiple_nodes( | |||
| func: fn(C, Arc<Cmd>) -> RedisFuture<'static, Response>, | |||
| cmd: &Arc<Cmd>, | |||
| only_primaries: bool, | |||
There was a problem hiding this comment.
for a different PR - I think we should pass the routing info to the function and that the function will retrieve its relevant addresses, so it could be used to other groups of nodes besides to PRIMARES/ALL_NODES (e.g. - specific shard, all replicas, group of nodes the user passes..)
There was a problem hiding this comment.
nihohit@0a7558d
as requested :)
This change implements the response_policy tip in the async cluster. https://redis.io/docs/reference/command-tips/#response_policy This means that the results from fan-out commands will be aggregated differently, based on the sent command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is based over https://github.com/nihohit/redis-rs/pull/5.
This change implements the response_policy tip in the async cluster.
https://redis.io/docs/reference/command-tips/#response_policy
This means that the results from fan-out commands will be aggregated
differently, based on the sent command.