Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment suggesting IonWriter isn't stable #300

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

dlurton
Copy link
Contributor

@dlurton dlurton commented Aug 10, 2020

Inspired by this question: #10 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlurton dlurton requested a review from tgregg August 10, 2020 22:01
@dlurton dlurton self-assigned this Aug 10, 2020
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #300 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
+ Coverage     63.87%   63.89%   +0.02%     
- Complexity     4806     4809       +3     
============================================
  Files           136      136              
  Lines         21052    21052              
  Branches       3813     3813              
============================================
+ Hits          13447    13452       +5     
+ Misses         6267     6264       -3     
+ Partials       1338     1336       -2     
Impacted Files Coverage Δ Complexity Δ
src/com/amazon/ion/impl/BlockedBuffer.java 51.70% <0.00%> (+0.60%) 81.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06752a3...13949be. Read the comment docs.

@dlurton dlurton merged commit b6842d5 into master Aug 10, 2020
@dlurton dlurton deleted the ion-writer-stable-comment branch August 10, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants