Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Reader.byteValue() in favor of a new Reader.uInt8ArrayValue() method #559

Closed
pbcornell opened this issue Feb 18, 2020 · 2 comments
Closed

Deprecate Reader.byteValue() in favor of a new Reader.uInt8ArrayValue() method #559

pbcornell opened this issue Feb 18, 2020 · 2 comments
Labels
api v5.0.0 issues for v5.0.0 release
Milestone
M7 (v5.0.0)

Comments

@pbcornell
Copy link

src/dom/Value.ts provides a clearer uInt8ArrayValue(): Uint8Array | null method; consider updating the Reader interface to follow suit.
@pbcornell pbcornell added the api label Feb 18, 2020
@zslayton zslayton modified the milestone: M4 Mar 26, 2020
@desaikd desaikd mentioned this issue Jan 27, 2021
Merged
@desaikd
Copy link
Contributor

desaikd commented Mar 2, 2023

Remove the deprecated method for v5.0.0 release.

@desaikd desaikd added the v5.0.0 issues for v5.0.0 release label Mar 2, 2023
@desaikd desaikd added this to the M7 (v5.0.0) milestone Mar 8, 2023
@desaikd desaikd mentioned this issue Mar 8, 2023
Merged
@desaikd
Copy link
Contributor

desaikd commented Mar 9, 2023

Fixed with #750

@desaikd desaikd closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api v5.0.0 issues for v5.0.0 release
Projects
None yet
Milestone
M7 (v5.0.0)
Development

No branches or pull requests
3 participants
@zslayton @pbcornell @desaikd