Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes deprecated method byteValue() for v5.0.0 release #750

Merged

Conversation

desaikd
Copy link
Contributor

@desaikd desaikd commented Mar 8, 2023

Issue #559

Description of changes:

This PR works on removing deprecated method byteValue() which has a new replacement uint8ArrayValue() method available alternatively.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@desaikd desaikd modified the milestone: M7 (v5.0.0) Mar 8, 2023
@desaikd desaikd requested a review from zslayton March 9, 2023 00:17
@desaikd desaikd merged commit a7541b0 into amazon-ion:v5.0.0-development Mar 9, 2023
desaikd added a commit that referenced this pull request Apr 24, 2023
* Drops support for Node 10.x, 12.x and adds 18.x (#723)

* move to native `BigInt` from `JSBI` (#721)

* Updates typedoc syntax to address warnings (#733)

* updates test-driver to es2020 (#736)

* Migrate linting from TSLint to ESLint (#737)

* adds changes for resolving ion-test-driver build issue (#748)

* adds changes to allow `dom.Decimal` construction from `Number` and `String` (#746)

* updates uglify version

* adds changes for upconverting JS value for dom collections (#749)

* removes deprecated method `byteValue()` for v5.0.0 release (#750)

* modifies `Struct#elements()` to return all field values (#754)

---------

Co-authored-by: Matthew Pope <81593196+popematt@users.noreply.github.com>
Co-authored-by: Delaney <delaneygillilan@gmail.com>
Co-authored-by: Zack Slayton <zack.slayton@gmail.com>
Co-authored-by: Andrey Lipatkin <400234+Litee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants